Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example links #131

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Update example links #131

merged 4 commits into from
Apr 12, 2021

Conversation

wipfli
Copy link
Contributor

@wipfli wipfli commented Apr 11, 2021

Launch Checklist

This pull requests updates the links to examples in JSDoc comments from Mapbox to MapLibre. The links are defined in the @see tags and they show up in the documentation website.

I did not migrate all existing examples to the new documentation website because some of them were incompatible with maplibregl or they required a mapbox access token, see maplibre/maplibre-gl-js-docs#36. Links to examples that were not migrated are removed.

  • ✅ confirm your changes do not include backports from Mapbox projects (unless with compliant license)
  • ✅ briefly describe the changes in this PR
  • 🔲 include before/after visuals or gifs if this PR includes visual changes
  • 🔲 write tests for all new functionality
  • 🔲 document any changes to public APIs
  • 🔲 post benchmark scores
  • 🔲 manually test the debug page
  • 🔲 apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • ✅ add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog>Update example links to https://maplibre.org/maplibre-gl-js-docs/</changelog>

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2021

Bundle size report:

Size Change: 0 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file Before After Change
maplibre-gl.js 196 kB 196 kB 0 B
maplibre-gl.css 8.87 kB 8.87 kB 0 B
ℹ️ View Details No major changes

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wipfli wipfli mentioned this pull request Apr 11, 2021
@nyurik nyurik merged commit fd16a60 into maplibre:main Apr 12, 2021
@wipfli wipfli deleted the update-example-links branch April 19, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants